chore: Upgrade replica to v0.5.5#559
Conversation
90a2c0b to
34b4ef2
Compare
34b4ef2 to
a399c39
Compare
|
After running for a few hours, the CPU can still increase to around 50%. It seems to be increasing at a slower pace than v0.5.4, and the "idle wake ups" are smaller. Another thing I noticed is that different from v0.5.2, the replica keeps generating checkpoints even when no messages are sent. Don't know if this is expected or can cause the cpu usage. |
|
Execution state snapshots are made at an interval to enable purging of older state. But it shouldn't have caused increasing CPU usage. There is something else going on, I'll investigate. |
|
Investigation of the CPU time is tracked here: https://github.com/dfinity-lab/dfinity/pull/3204 |
|
A fix to replica is under view at https://github.com/dfinity-lab/dfinity/pull/3270 |
|
We need to first cut new replica release 0.5.6 before updating the reference revision here. However, there is another problem related to crypto key setup that prevents single node replica from running. |
|
Do we have a notion of cherry pick in the release process, where we can cut a release up to certain PR, plus a set of PRs beyond the cut point? |
That will require a separate branch (e.g. just for v0.5.5) instead of master. I actually have it ready in https://github.com/dfinity-lab/dfinity/pull/3204. But the bigger question is whether it is desirable to maintain a branch release that deviates from master. Let's see what @p-shahi has to say about it. |
update: will provide a release from branch with cherry picks for replica 0.5.6 ==== (if possible, I would suggest we wrap the crypto key setup changes around a feature flag. then, disable this feature for the replica bundled inside dfx - this should be straightforward and wouldn't require a new branch) @hansl @chenyan-dfinity please communicate the urgency of needing to push out a new SDK release so that I know whether to immediately provide you a new tag (create a new branch with cherry picks) or if we can spend some time trying to get feature flags for this change |
|
superseded by #591 |
## Changelog for advisory-db: Branch: master Commits: [rustsec/advisory-db@fa47ec0c...8e1ad08e](rustsec/advisory-db@fa47ec0...8e1ad08) * [`7feb037b`](rustsec/advisory-db@7feb037) RUSTSEC-2020-0017.md (use-after-free in internment) is fixed ([RustSec/advisory-db#554](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/554)) * [`a3efac59`](rustsec/advisory-db@a3efac5) Add "Publish Web" GitHub Action ([RustSec/advisory-db#557](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/557)) * [`50451dd5`](rustsec/advisory-db@50451dd) Publish Web: fix rustsec-admin install ([RustSec/advisory-db#558](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/558)) * [`8e1ad08e`](rustsec/advisory-db@8e1ad08) Publish Web: fix YAML indenting ([RustSec/advisory-db#559](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/559))
## Changelog for advisory-db: Branch: master Commits: [rustsec/advisory-db@fa47ec0c...8e1ad08e](rustsec/advisory-db@fa47ec0...8e1ad08) * [`7feb037b`](rustsec/advisory-db@7feb037) RUSTSEC-2020-0017.md (use-after-free in internment) is fixed ([RustSec/advisory-db#554](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/554)) * [`a3efac59`](rustsec/advisory-db@a3efac5) Add "Publish Web" GitHub Action ([RustSec/advisory-db#557](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/557)) * [`50451dd5`](rustsec/advisory-db@50451dd) Publish Web: fix rustsec-admin install ([RustSec/advisory-db#558](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/558)) * [`8e1ad08e`](rustsec/advisory-db@8e1ad08) Publish Web: fix YAML indenting ([RustSec/advisory-db#559](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/559))
@chenyan-dfinity reported CPU usage of replica would increase dramatically if running for longer than a couple hours for v0.5.4. This is likely related to a performance degradation problem that was already fixed in a later version. So we just cut a v0.5.5 release, and this PR is to see if everything works out for sdk.